Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps(sdkv3): implement logging and endpoint override for client builder. #6441

Merged
merged 33 commits into from
Feb 11, 2025
Merged

deps(sdkv3): implement logging and endpoint override for client builder. #6441

merged 33 commits into from
Feb 11, 2025

Conversation

Hweinstock
Copy link
Contributor

Problem

The V3 client builder currently only adds telemetry. We want some additional functionality on each request/response.

Solution

  • Allow user to override the endpoint used by the sdk.
  • Add debugging messages for each request and response.
  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Hweinstock
move in main file
f464309
@Hweinstock
add test file
afc0a26
@Hweinstock
implement middlestack
75822d7
@Hweinstock
add more detail to telemetry emitted
be3c42a
@Hweinstock
add a default retry strategy
89ef745
@Hweinstock
use class type instead of interface
4890f73
@Hweinstock
give up type info so that it compiles
ccfd462
@Hweinstock
refactor types to have any middleware
0675afe
@Hweinstock
remove interface
3e8caf6
@Hweinstock
remove unused types
67784e1
@Hweinstock
simplify naming
1d29b18
@Hweinstock
merge in upstream changes
97375a3
@Hweinstock
rename test file
4500cdc
@Hweinstock
Merge branch 'sdkv3/startMigration' into sdkv3/middlestack2
4e4f53f
@Hweinstock
change name to temp
4e2dffe
@Hweinstock
switch name to lower case
470e0f5
@Hweinstock
Merge branch 'feature/sdkv3' into sdkv3/startMigration
6fc31e5
@Hweinstock
add link to relevant issue
6a04c98
@Hweinstock
move dep to core module
58809be
@Hweinstock
improve middleware typing
4880c16
@Hweinstock
remove redundant type
6dc2405
@Hweinstock
improve typing
222ff04
@Hweinstock
refactor: customerUserAgent -> userAgent
f0adfee
@Hweinstock
refactor: remove blank line
7bd08b3
@Hweinstock
refactor: use partialClone over omitIfPresent
688899b
@Hweinstock
Merge branch 'feature/sdkv3' into sdkv3/startMigration
3cec376
@Hweinstock
refactor: add depth field to partialClone
312c93c
@Hweinstock
refactor: rename test file
a110c1f
@Hweinstock
merge: resolve conflicts with upstream
bee9e06
@Hweinstock
refactor: clean up tests
9a3aab9
@Hweinstock Hweinstock marked this pull request as ready for review January 27, 2025 19:44
@Hweinstock Hweinstock requested a review from a team as a code owner January 27, 2025 19:44
@Hweinstock Hweinstock merged commit 66f050c into aws:feature/sdkv3 Feb 11, 2025
17 checks passed
@Hweinstock Hweinstock deleted the sdkv3/middlestack2 branch February 11, 2025 17:32
@justinmk3
Copy link
Contributor

justinmk3 commented Feb 11, 2025 •
edited
Loading

The "endpoint override" here may help with:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpinkney-aws jpinkney-aws jpinkney-aws approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hweinstock @justinmk3 @jpinkney-aws